Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use creator of invitation as From field in invitation mails #34899

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Use creator of invitation as From field in invitation mails #34899

merged 1 commit into from
Mar 26, 2019
+1 −0

Conversation

valentinstn
Copy link

Motivation and Context

Invitations to events are send by people and not the technical email address. Invitees expect to get an invitation from another person, not a service.

How Has This Been Tested?

Manually tested in our environment and by other users here: #25470 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #34899 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34899      +/-   ##
============================================
+ Coverage     65.35%   65.35%   +<.01%     
  Complexity    18488    18488              
============================================
  Files          1208     1208              
  Lines         69975    69976       +1     
  Branches       1280     1280              
============================================
+ Hits          45732    45733       +1     
  Misses        23871    23871              
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.76% <100%> (ø) 18488 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php 85% <100%> (+0.38%) 14 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c4ba1...3a9b9dd. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 26, 2019 •
edited
Loading

Codecov Report

Merging #34899 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34899      +/-   ##
============================================
+ Coverage     65.35%   65.35%   +<.01%     
  Complexity    18488    18488              
============================================
  Files          1208     1208              
  Lines         69975    69976       +1     
  Branches       1280     1280              
============================================
+ Hits          45732    45733       +1     
  Misses        23871    23871              
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.76% <100%> (ø) 18488 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php 85% <100%> (+0.38%) 14 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c4ba1...3a9b9dd. Read the comment docs.

@PVince81 PVince81 added this to the development milestone Mar 26, 2019
@PVince81 PVince81 merged commit 96f1fef into owncloud:master Mar 26, 2019
@PVince81
Copy link
Contributor

@m55c55 can you backport this to the stable10 branch ? just send a PR with the same change to stable10

@valentinstn valentinstn mentioned this pull request Mar 26, 2019
Merged
10 tasks
@valentinstn
Copy link
Author

@PVince81 Done

@phil-davis
Copy link
Contributor

Backport stable10 is PR #34901

magicWF
magicWF reviewed Dec 7, 2019
View reviewed changes
Copy link

@magicWF magicWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This correction causes problems when sending mails when the OC-Server tries to send mails with foreign senders (domains for which the OC MTA is not responsible). In the worst case, my server should send a mail to Apple or Google that actually comes from them. In order to reduce the amount of SPAM, the easiest method is not to accept mail from your own domain if it comes from other servers. This is done using techniques like DMARC (RFC5322), SPF, DKIM.

Therefore, this patch should not be published in this way!

@magicWF magicWF mentioned this pull request Dec 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicWF magicWF magicWF left review comments

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@Julian1998 Julian1998 Awaiting requested review from Julian1998

Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
development
Development

Successfully merging this pull request may close these issues.
7 participants
@valentinstn @CLAassistant @PVince81 @phil-davis @DeepDiver1975 @magicWF @valentinsteinwandter